Allow tokens to be provided via properties files

[andy-berry-dev]

• allowing token replacements to be specified via config files (allow the use of tokens when exporting to static files #749)
• supporting a number of BRJS. 'system' tokens (move the bundlePath token logic into a single shared location #775)

BladeRunnerJS/brjs-site#113 is an associated PR which contains docs updates.

[dchambers]

The exception for the invalid token XXX can be fixed by adding XXX=@xxx@ to app-properties/default.properties.

Yes, let's do it that way since then we can point other people at this work around if they ever hit the same issue.

[thecapdan]

Hi @andyberry88 . A few issues with this one.

1: The js bundle is truncated when I load the dashboard or any app on this build. This is the end of my dashboard bundle:

var FieldValuePropertyListener = require('br/presenter/node/FieldValuePropertyListener');
var ValidSelectionValidator = require('br/presenter/validator/ValidSelectionValidator');
va

2: Even when I include default.properties file with a replacement for my token, I still get the following error:

Caused by: org.bladerunnerjs.appserver.util.TokenReplacementException: An error occurred when the token finder 'JndiTokenFinder' attempted to locate a replacement for the the token 'IIII'.
        at org.bladerunnerjs.appserver.util.JndiTokenFinder.findTokenValue(JndiTokenFinder.java:38)

3: Can we have some nice docs on how to use this feature?

[andy-berry-dev]

1: The js bundle is truncated when I load the dashboard or any app on this build. This is the end of my dashboard bundle:

This was caused by the incorrect encoding being used when calculating the Content-Length header and the browser truncating the response based on the header value being too small. Now fixed.

Even when I include default.properties file with a replacement for my token, I still get the following error:

I can't reproduce this. Tokens are working without any problems for me. Waiting for @thecapdan to confirm is this now works.

Can we have some nice docs on how to use this feature?

Docs changes branch is at BladeRunnerJS/brjs-site#113.

[andy-berry-dev]

The exception for the invalid token XXX can be fixed by adding XXX=@xxx@ to app-properties/default.properties.

This doesn't quite work. Replacing @XXX@ with @XXX@ gets past the 'static' replacement but because the token is still there the JNDI token filter tries to replace the same thing and blows up because there is no replacement. The fix is to replace @XXX@ with @xxx@ since BRJS only supports uppercase characters in the token format. So app-properties/default.properties should look like XXX=@xxx@. I've verified with work in amCharts with @thecapdan.

[thecapdan]

the 3 issues i described above have been addressed and fixed.

the suggested solution for the @III@ tokens did not work, changing the tokens to lowercase will work, i.e. IIII=@iii@

there's an encoding issue when we run the tests on windows, andrew is having a look