Add service!$data source module
#1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
performance impact is not detectable in our test-app (fxtrader). require('service!$data') behaves as expected. test coverage looks good |
thecapdan
added a commit
that referenced
this pull request
Jan 5, 2016
Add `service!$data` source module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
service!$datasource module that lists services and their dependencies.There could be a slight performance/memory hit here since in order to detect services in NamespacedJS we have to do a second pass looking for
getService('...')calls. I've done some basic investigation and it seems to be negligible, but we should probably double check this with a larger app.