Autocomplete improvements #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dogoku, thanks for the pull-request 😄. Before we can proceed there is one commit that will need to be reverted, and I noticed that there are no tests for any of these changes. It looks like there are tests in |
dogoku
force-pushed
the
autocomplete-improvements
branch
2 times, most recently
from
98cba42 to
8abb6a1
Compare
|
Hello, I've updated my commits to include tests in all of them. I also removed the commit that drops support for ie8 following @dchambers suggestion Unfortunately, github doesn't handle rebases/squishes as well as Stash does, so you can't really notice something happened, unless you actually go into the particular commit and know it's previous state. Regardless, I believe this PR is good to go |
added 8 commits
February 8, 2016 14:49
These are used to add a class to the input, indicating the menu is open and to force a high z-index on the menu
By blurring, the natural tab flow of the page is broken Also removed the keydown listener completely, since select gets triggered before it making this listener obsolete.
dogoku
force-pushed
the
autocomplete-improvements
branch
from
8abb6a1 to
fd4ff25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR consisting of a number of improvements/changes for the JQueryAutoCompleteControl
I've split the changes into seperate commits, to make things a bit easier. Some commit messages have more than one lines so do bear that in mind.