Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix convertInchesToCentimeters function #518

Closed
paolomangiadev opened this issue Oct 26, 2017 · 3 comments · Fixed by #529
Closed

fix convertInchesToCentimeters function #518

paolomangiadev opened this issue Oct 26, 2017 · 3 comments · Fixed by #529

Comments

@paolomangiadev
Copy link
Contributor

paolomangiadev commented Oct 26, 2017

There is currently a method called convertInchesToCentimeters that lives in /lib/convertInchesToCentimeters.js.
It is incomplete and needs to be fixed!

Description:
A number indicating a measurement in inches is passed to the method and the return is the same measurement converted in centimeters. e.g. 7in => 17.78003556007112cm

Acceptance Criteria:

  1. Running yarn test convertInchesToCentimeters results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional:
  • write one or two more tests surrounding the method you are solving to account for potential edge cases.
  • add the option of rounding the resulting measurement (centimeters).

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

@lmauromb
Copy link
Contributor

I'll take it!

@roseg43
Copy link
Contributor

roseg43 commented Oct 26, 2017

Was just taking a look at this and @paolomangiadev , it looks like the initial tests for this method pass no matter what.

The expect in "Should return converted inches to centimeters" always evaluates to true. Something to keep in mind @lmauromb

@BlakeGuilloud
Copy link
Owner

Marking as in progress. @lmauromb - take a look at those tests while you're digging around, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants