Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/convert inches to centimeters #529

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Fix/convert inches to centimeters #529

merged 3 commits into from
Oct 27, 2017

Conversation

lmauromb
Copy link
Contributor

@lmauromb lmauromb commented Oct 26, 2017 •
edited
Loading

Closes #518
Adds #530

  • Running yarn lint does not trigger any linter errors
  • The test of the method you have fixed is passing
  • You have written a new skeleton method for someone else to work on!
  • You have written tests to accompany your skeleton method

BlakeGuilloud
BlakeGuilloud approved these changes Oct 27, 2017
View reviewed changes
Copy link
Owner

@BlakeGuilloud BlakeGuilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! THanks for your contribution @lmauromb ! Do you mind creating a new Issue for your skeleton? thanks!

@BlakeGuilloud BlakeGuilloud merged commit 0fb9c4c into BlakeGuilloud:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlakeGuilloud BlakeGuilloud BlakeGuilloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix convertInchesToCentimeters function
2 participants
@lmauromb @BlakeGuilloud