Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix convertCentimetersToInches function #530

Open
lmauromb opened this issue Oct 26, 2017 · 4 comments
Open

fix convertCentimetersToInches function #530

lmauromb opened this issue Oct 26, 2017 · 4 comments

Comments

@lmauromb
Copy link
Contributor

There is currently a method called convertCentimetersToInches that lives in /lib/convertCentimetersToInches.js.
It is incomplete and needs to be fixed!

Acceptance Criteria:

  1. Running yarn test convertCentimetersToInches results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

@saiftase
Copy link
Contributor

I think I'll work on this.

@BlakeGuilloud
Copy link
Owner

Sounds good @saiftase ! Thanks!

@anurag-rai
Copy link

Hey, if this is up for grabs, I'd like to work on it

@ktilcu
Copy link
Collaborator

ktilcu commented Oct 2, 2018

@anurag-rai go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants