Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI -> Paths panel ...fix alignment of vertical scrollbar [cosmetic] #1508

Closed
giantclambake opened this issue Nov 11, 2024 · 2 comments
Closed

GUI -> Paths panel ...fix alignment of vertical scrollbar [cosmetic] #1508

giantclambake opened this issue Nov 11, 2024 · 2 comments
Assignees
@midwan

Comments

@giantclambake
Copy link

...some of this goes back to #1409 --- with the latest guisan updates, that has largely been addressed, however I noticed it also revealed another goofy in the Paths panel....

ex

...that purple vertical line should not be present at the left edge of the scrollbar...

... .theme file attached ...

TIA

pastel.theme.gz
@midwan midwan self-assigned this Nov 12, 2024
midwan added a commit that referenced this issue Nov 12, 2024
@midwan
refactor: make scrollbar width 14 pixels wide (#1508)
e865c9b 
The scrollbar width in Guisan is a bit too small. Making it 2 pixels wider looks better
@midwan
Copy link
Collaborator

midwan commented Nov 12, 2024

@giantclambake
See if the above commit makes things better :)

@giantclambake
Copy link
Author

@midwan ...much better now with that commit, kudos ;)

ex

Closing - fixed by e865c9b

midwan added a commit that referenced this issue Nov 23, 2024
@midwan
Squashed commit of the following:
5f49fec 
commit 75572f4
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 23 10:59:04 2024 +0100

    bugfix: ensure CPack also has correct capitalization (fixes #1514)

commit 2e70acc
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 23 10:45:29 2024 +0100

    bugfix: Linux builds should have PROJECT_NAME in lower case

    Looks like the CMAKE_SYSTEM_NAME variable is only valid AFTER the project is set.
    We need a capitalized name for macOS builds, but lowercase for linux ones.

commit a1591ee
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 20:55:07 2024 +0100

    chore: only write config options if they are enabled

    - Manual Crop
    - Drawbridge

    These options would be written to the config always, even if not enabled

commit 249a132
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 20:48:03 2024 +0100

    chore: bump options version to 7.0.0

commit 85044a8
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:57:06 2024 +0100

    enhancement: add ".vbi" in global ROM extensions also #1507

commit 63fee15
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:54:22 2024 +0100

    fix typo

    It's not vdi, but vbi

commit 2c1e921
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:52:07 2024 +0100

    bugfix: allow .vdi selection in Expansions ROMs #1507

    These types of files are VGA rom files, but they were filtered out based on the filename extensions

commit 1718e2c
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 18:38:44 2024 +0100

    bugfix: #1507 Expansions GUI CPU board fixes

    When selecting a CPU board from the dropdown, the sub-options did not get enables as expected

commit f7f09bf
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 08:39:49 2024 +0100

    Update README.md

    Remove obsolete info about bypassing security on MacOS installation

commit 9d0c218
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 00:46:20 2024 +0100

    ci: added missing team ID

commit a197c86
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 00:36:07 2024 +0100

    ci: added notary service steps

commit 10fe364
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 22 00:04:40 2024 +0100

    ci: fix macOS signing

commit 97a7021
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 23:53:19 2024 +0100

    ci: fix capitalization for MacOS App bundle

commit 0fe6e54
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 23:53:00 2024 +0100

    ci: Add Apple certificate signing to dylibs and app bundle

commit 0344272
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 20:29:38 2024 +0100

    ci: Added missing create keychain step

commit 935fcda
Author: Dimitris Panokostas <[email protected]>
Date:   Thu Nov 21 20:09:34 2024 +0100

    ci: add apple signing certificate setup in workflow

commit d9804b3
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 16 10:48:46 2024 +0100

    Update README.md (#1511)

commit 62fa27e
Author: Dimitris Panokostas <[email protected]>
Date:   Wed Nov 13 19:56:56 2024 +0100

    refactor: Fix compiler warnings and sync guisan with upstream changes

commit e865c9b
Author: Dimitris Panokostas <[email protected]>
Date:   Tue Nov 12 17:09:16 2024 +0100

    refactor: make scrollbar width 14 pixels wide (#1508)

    The scrollbar width in Guisan is a bit too small. Making it 2 pixels wider looks better

commit 3c7b6c1
Author: Dimitris Panokostas <[email protected]>
Date:   Sun Nov 10 15:31:17 2024 +0100

    chore: minor guisan cleanup

    - Changed listmodel's clear_elements() to clear()
    - Renamed references accordingly
    - Changed Listmodel destructor to = default

commit 336e134
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 9 17:54:12 2024 +0100

    chore: tabs to spaces

    Change tabs to spaces in some files, to sync with upstream

commit 78f2eef
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 9 13:27:53 2024 +0100

    bugfix: Expansions panel refresh was buggy (fixes #1501)

commit d37b528
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 9 12:55:54 2024 +0100

    bugfix: Expansion Rom file option would not always get saved (#1501)

commit 067c5e5
Author: Dimitris Panokostas <[email protected]>
Date:   Sat Nov 9 11:46:40 2024 +0100

    enhancement: check for savestates in the savestate dir as well (fixes #1498)

    If a savestate is passed in the command line when starting up, do a secondary check for the filename inside the defined savestates directory.
    This allows for scenarios where just the filename can be passed as the parameter, instead of the full path to it as well.

commit 0de7f3a
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 8 14:13:59 2024 +0100

    1477 implement latest guisan changes (#1504)

    * Merge latest Guisan updates from upstream

    * Added drawChildren to container

    Our SelectorEntry class would not draw the children otherwise

    * Add 2 pixels of height to Checkboxes, to avoid font clipping

    * bugfix: Fix Dropdown scrollarea would obstruct content (fixes #1476)

    * bugfix: Dropdown scroll bar would still get in the way (#1476)

    * bugfix: Add 1 more pixel of padding in Textfield (fixes #1478)

commit c1aa68b
Author: Didier Malenfant <[email protected]>
Date:   Thu Nov 7 14:25:52 2024 +0100

    bugfix: Fixed uninitialized path variable (#1502)

commit 56daee6
Author: Dimitris Panokostas <[email protected]>
Date:   Tue Nov 5 22:19:31 2024 +0100

    refactor: added more ifdefs

commit b7077ac
Author: Dimitris Panokostas <[email protected]>
Date:   Tue Nov 5 22:19:13 2024 +0100

    chore: remove opencollective links

commit bd11afa
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 1 16:51:31 2024 +0100

    Update c-cpp.yml

commit 664b624
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 1 15:42:59 2024 +0100

    bugfix: Fixed mouse motion in different rotation angles

commit a3148f9
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 1 15:25:19 2024 +0100

    bugfix: when rotating display, mouse input should be rotated as well

commit 87a9570
Author: Dimitris Panokostas <[email protected]>
Date:   Fri Nov 1 15:12:54 2024 +0100

    perf: avoid using std::endl on streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@midwan midwan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@midwan @giantclambake