Somewhat Improves display of very dense QRs #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Error correction set to "L", which can make very dense QRs slightly less dense 2) Display of QR in QR Export page increased in size, with container going from 235 height to 275, as tall as it could go on the smallest iPhone screens without making the export text area useless. For a next step, I suggest the enhancement in issue #80
ChristopherA
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Built successfully on MacBook Pro M1 (2020) on Big Sur 11.4 using Xcode 12.5.1, on both iPhone 11 Max Pro, and iPod touch 7th, both running iOS 14.6.
Short term fix for #78 on my iPhone works — I can read the QR on iPhone, and can scan the QR to my iPod touch. However, though I can scan the original QR on my iPod Touch 7th, I still can't share it on either view screen (see #82) as it is cut off. I was able to scan from details screen however (though once I got a "unknown format error" which I've not seen before, but 2nd time worked).
Approved for merge to master and release to Apple as a bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a next step, I suggest the enhancement in issue #80