Revert previous changes to vendored code

[DimitriPapadopoulos]

No description provided.

[FrancescAlted]

Uh, the bitshuffle codec here is actually a copy of the upstream. Frankly, for future updates in upstream, I'd prefer keeping this code in sync.

[DimitriPapadopoulos]

Indeed, I will revert all previous changes. That said, perhaps the block below should be kept in this file, in addition to the Blosc block:

/*
 * Bitshuffle - Filter for improving compression of typed binary data.
 *
 * Author: Kiyoshi Masui <[email protected]>
 * Website: http://www.github.com/kiyo-masui/bitshuffle
 * Created: 2014
 *
 * See LICENSE file for details about copyright and rights to use.
 *
 */

The rationale is both to warn that the code is vendored, and to comply with the licence:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

[FrancescAlted]

Indeed, I will revert all previous changes. That said, perhaps the block below should be kept in this file, in addition to the Blosc block:

/*
 * Bitshuffle - Filter for improving compression of typed binary data.
 *
 * Author: Kiyoshi Masui <[email protected]>
 * Website: http://www.github.com/kiyo-masui/bitshuffle
 * Created: 2014
 *
 * See LICENSE file for details about copyright and rights to use.
 *
 */

The rationale is both to warn that the code is vendored, and to comply with the licence:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

Agreed!

[DimitriPapadopoulos]

Most of 3rd party code lives under internal-complibs.

Are these 3 macros the only piece of code borrowed from kiyo-masui/bitshuffle? Is there vendored code elsewhere too?

[DimitriPapadopoulos]

The relevant part of the code have been reverted to its previous state.

[FrancescAlted]

Most of 3rd party code lives under internal-complibs.

Are these 3 macros the only piece of code borrowed from kiyo-masui/bitshuffle? Is there vendored code elsewhere too?

No, all the bitshuffle code is from the bitshuffle project (actually, Kiyo helped us in integrating it better in C-Blosc).

[DimitriPapadopoulos]

It would be clearer if files could be just copied over from kiyo-masui/bitshuffle, but kiyo-masui/bitshuffle#11 seems to imply it's not straightforward.

[FrancescAlted]

LGTM. Thanks @DimitriPapadopoulos !

[DimitriPapadopoulos]

Should I revert changes to other files? In most bitshuffle-*.[hc] files, I changed header inclusion stuff, but in a few files, I modified macros.