Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #528
I'm unsure about the correctness of this change but I ran all the unit tests and they all passed. The attached test fails before the addition of
_cycle_buffers
and passes after adding_cycle_buffers
.My rationale for the fix is that all the sites that were swapping buffers looked like they intended to rotate 3 variables, but actually lose a variable each time:
is equivalent to
So that any filter which writes to the
_tmp
buffer will be corrupting its own input.