G29 endstop handling #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blue-Marlin
force-pushed
the
RCBugFix
branch
from
49ad003 to
8dccd5a
Compare
Shift the definition of `clean_up_after_endstop_move()` close to `setup_for_endstop_move()` to make them easier to compare. Remove `enable_endstops(true);` from `setup_for_endstop_move()`. Insert `enable_endstops(true/false)` in `run_z_probe()` directly before or next to the relevant moves like it is done in `homeaxis()`. Add `static int8_t h_endstops_set = 0;` to remember if `enable_endstops()` was set by M120 or M121. Pimp up `clean_up_after_endstop_move()` to recognize it the endstops where set by M120, M121. Use `clean_up_after_endstop_move()` when G28 is ready instead of the same literal code. Sync planner before the actual moves in `run_z_probe()` are done, to guarantee the move is only in z direction.
AnHardt
force-pushed
the
G29-endstop-handling
branch
from
148bb34 to
d02d4d8
Compare
Blue-Marlin
added a commit
that referenced
this pull request
May 2, 2016
Fix for #6 3593, MarlinFirmware#3648 this time excludung 'DEL' instead of accidently '~'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.