Try last version 1.14.1 (#753)

Co-authored-by: Luc Grosheintz <[email protected]>
BlueBrain · May 26, 2023 · 4573fd3 · 4573fd3
1 parent b5d67bd
commit 4573fd3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -86,7 +86,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        hdf5_version : [ hdf5-1_8_23, hdf5-1_10_9, hdf5-1_12_2, hdf5-1_14_0 ]
+        hdf5_version : [ hdf5-1_8_23, hdf5-1_10_10, hdf5-1_12_2, hdf5-1_14_1 ]
 
     steps:
     - uses: actions/checkout@v3
@@ -102,7 +102,7 @@ jobs:
         wget https://github.com/HDFGroup/hdf5/archive/refs/tags/${{ matrix.hdf5_version }}.tar.gz --output-document hdf5.tar.gz
         tar xf hdf5.tar.gz
         mkdir -p hdf5-${{ matrix.hdf5_version }}/BUILD && cd hdf5-${{ matrix.hdf5_version }}/BUILD
-        cmake .. -GNinja -DCMAKE_INSTALL_PREFIX=$HOME/${{ matrix.hdf5_version }} -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DUSE_LIBAEC=ON
+        cmake .. -DCMAKE_BUILD_TYPE=Release -GNinja -DCMAKE_INSTALL_PREFIX=$HOME/${{ matrix.hdf5_version }} -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DUSE_LIBAEC=ON
         ninja && ninja install
 
     - name: Build

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -41,7 +41,7 @@ jobs:
         fetch-depth: 2
         submodules: true
 
-    - name: Build and test for code coverage
+    - name: Build for code coverage
       run: |
         CMAKE_OPTIONS=(
           -GNinja
@@ -54,11 +54,12 @@ jobs:
           -DCMAKE_CXX_FLAGS="-coverage -O0"
         )
         source $GITHUB_WORKSPACE/.github/build.sh
-        cd $HIGHFIVE_BUILD
-        (cd $GITHUB_WORKSPACE;  lcov --capture  --initial --directory . --no-external --output-file build/coverage-base.info)
-        cmake --build $HIGHFIVE_BUILD --target test
-        (cd $GITHUB_WORKSPACE; lcov --capture  --directory . --no-external --output-file build/coverage-run.info)
-        lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info
+    - name: Test for code coverage
+      run: |
+        lcov --capture  --initial --directory . --no-external --output-file build/coverage-base.info
+        (cd build; cmake --build . --target test)
+        lcov --capture  --directory . --no-external --output-file build/coverage-run.info
+        (cd build; lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info)
     - uses: codecov/codecov-action@v3
       with:
         files: ./build/coverage-combined.info

diff --git a/tests/unit/tests_high_five_base.cpp b/tests/unit/tests_high_five_base.cpp
@@ -291,12 +291,12 @@ TEST_CASE("Test group properties") {
     File file(file_name, File::Truncate, fapl);
 
     GroupCreateProps props;
-    props.add(EstimatedLinkInfo(1000, 500));
+    props.add(EstimatedLinkInfo(10, 60));
     auto group = file.createGroup("g", props);
     auto sizes = group.getEstimatedLinkInfo();
 
-    CHECK(sizes.first == 1000);
-    CHECK(sizes.second == 500);
+    CHECK(sizes.first == 10);
+    CHECK(sizes.second == 60);
 }
 
 TEST_CASE("Test allocation time") {