Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test bug in a FixedLenStringArray ctor. #797

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jul 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #797 (ce1a3d1) into master (59e6f41) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   84.18%   84.26%   +0.08%     
==========================================
  Files          68       68              
  Lines        4754     4779      +25     
==========================================
+ Hits         4002     4027      +25     
  Misses        752      752              
Impacted Files Coverage Δ
include/highfive/bits/H5DataType_misc.hpp 79.59% <100.00%> (-0.25%) ⬇️
tests/unit/tests_high_five_base.cpp 99.69% <100.00%> (+<0.01%) ⬆️

@1uc 1uc marked this pull request as ready for review July 11, 2023 07:37
@1uc 1uc requested a review from alkino July 11, 2023 07:38
Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@1uc 1uc merged commit 2c8b6b7 into master Jul 11, 2023
@1uc 1uc deleted the 1uc/fix-fixlen-buffer branch July 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants