Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Width, Total Height and Total Depth features #973

Closed
anilbey opened this issue Oct 26, 2021 · 5 comments · Fixed by #974
Closed

Total Width, Total Height and Total Depth features #973

anilbey opened this issue Oct 26, 2021 · 5 comments · Fixed by #974
Assignees

Comments

@anilbey
Copy link

anilbey commented Oct 26, 2021

Greetings, among some other features, the HIPPOCAMPUS portal requires these 3 features for each neurite to be provided for a given morphology ticket url.

  • Total Width
  • Total Height
  • Total Depth

As suggested on the ticket ticket url, these features can be computed by subtracting the max point on the bounding box from the min point for each axes.

Instead of implementing these features in a 3rd party script/package I think including them directly in NeuroM is more meaningful. What do you think?

@eleftherioszisis
Copy link
Contributor

It makes sense to me to have these features in NeuroM. I introduced them at the Morphology level.

@anilbey
Copy link
Author

anilbey commented Oct 28, 2021

Thanks @eleftherioszisis I am testing the PR now.

@anilbey
Copy link
Author

anilbey commented Oct 28, 2021

I can't get the value for the neurite. For morphology it works fine but Armando also wants to see these values for neurites.

nm.get("total_length", morph_factsheet_builder.morphology) # works
nm.get("total_length", morph_factsheet_builder.morphology, neurite_type=neurite_types[0]) # works

nm.get("total_height", morph_factsheet_builder.morphology) # works
nm.get("total_height", morph_factsheet_builder.morphology, neurite_type=neurite_types[0]) # fails

@eleftherioszisis
Copy link
Contributor

Indeed. Right now it's only on the Morphology level as I described.

What would be the expected value of the:

nm.get("total_height", morph_factsheet_builder.morphology, neurite_type=neurite_types[0])

Would it be a single total_height value of all the neurites in the morphology with that specific type?

@anilbey
Copy link
Author

anilbey commented Oct 28, 2021

Would it be a single total_height value of all the neurites in the morphology with that specific type?

Yes exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants