Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new features total_width, total_height and total_depth #974

Merged
merged 9 commits into from
Oct 29, 2021
Merged

Add new features total_width, total_height and total_depth #974

merged 9 commits into from
Oct 29, 2021

Conversation

eleftherioszisis
Copy link
Contributor

Three new features are added at the Morphology level, corresponding to the total extents along the bounding box directions.
The following naming-axes convention is used:

total_width  : x
total_height : y
total_depth  : z

Closes #973

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #974 (0b5eccd) into master (819e5ee) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #974   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2141      2156   +15     
=========================================
+ Hits          2141      2156   +15

@arnaudon arnaudon mentioned this pull request Oct 29, 2021
Closed
anilbey
anilbey approved these changes Oct 29, 2021
View reviewed changes
Copy link

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@anilbey
Copy link

anilbey commented Oct 29, 2021 •
edited
Loading

Is coverage.xml supposed to be added to the commit?

@anilbey
Copy link

anilbey commented Oct 29, 2021

Also the morphology-2D.html and morphology-3D.html

@anilbey
Copy link

anilbey commented Oct 29, 2021

Maybe .coverage* can be added to the .gitignore

@eleftherioszisis
Copy link
Contributor Author

I added .coverage.* because otherwise, it would also ignore the .coveragerc file.

anilbey
anilbey approved these changes Oct 29, 2021
View reviewed changes
Copy link

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think someone with the write access should also approve the changes.

joni-herttuainen
joni-herttuainen approved these changes Oct 29, 2021
View reviewed changes
Copy link

@joni-herttuainen joni-herttuainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleftherioszisis eleftherioszisis merged commit 5a48859 into master Oct 29, 2021
@eleftherioszisis eleftherioszisis deleted the new-features branch October 29, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilbey anilbey anilbey approved these changes

@joni-herttuainen joni-herttuainen joni-herttuainen approved these changes

@arnaudon arnaudon Awaiting requested review from arnaudon

@GianlucaFicarelli GianlucaFicarelli Awaiting requested review from GianlucaFicarelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Total Width, Total Height and Total Depth features
5 participants
@eleftherioszisis @codecov-commenter @anilbey @arnaudon @joni-herttuainen