Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape related features #1013

Merged
merged 16 commits into from
Mar 28, 2022
Merged

Shape related features #1013

merged 16 commits into from
Mar 28, 2022

Conversation

eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented Mar 24, 2022 •
edited
Loading

  • Moved convex_hull to morphmath and reverted to the old way of taking an obj in neurom.geom
  • Added features aspect_ratio, circularity, shape_factor

Implements #1010 #1011 #1012

@eleftherioszisis eleftherioszisis self-assigned this Mar 24, 2022
@eleftherioszisis eleftherioszisis marked this pull request as ready for review March 24, 2022 14:53
adrien-berchet
adrien-berchet reviewed Mar 24, 2022
View reviewed changes
neurom/features/morphology.py Show resolved Hide resolved
neurom/features/morphology.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
eleftherioszisis and others added 2 commits March 24, 2022 16:48
@eleftherioszisis @adrien-berchet
Update neurom/features/morphology.py
06ad464 
Co-authored-by: Adrien Berchet <[email protected]>
@eleftherioszisis @adrien-berchet
Update setup.py
bc9d567 
Co-authored-by: Adrien Berchet <[email protected]>
lidakanari
lidakanari approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@lidakanari lidakanari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@eleftherioszisis eleftherioszisis merged commit cef7800 into master Mar 28, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/aspect-ratio branch March 28, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-berchet adrien-berchet adrien-berchet approved these changes

@lidakanari lidakanari lidakanari approved these changes

Assignees

@eleftherioszisis eleftherioszisis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleftherioszisis @adrien-berchet @lidakanari