Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new feature of length above soma #1023

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented Apr 13, 2022

New feature for calculating the fraction of neurite length above the soma, where the up direction is determined by the up argument.

Implements #1022

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor question

neurom/features/morphology.py Show resolved Hide resolved
@adrien-berchet
Copy link
Member

Ah and just another thing, could a user need this feature using an arbitrary axis?

Copy link
Contributor

@lidakanari lidakanari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, spliting segments is not required and an arbitrary axis can be added if needed in the future. For the current needs this should be sufficient imo.

@eleftherioszisis eleftherioszisis merged commit dd28360 into master Apr 14, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/length-above-soma branch April 14, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants