-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path length option to sholl analysis #1053
Conversation
086ab92
to
3d142e2
Compare
LGTM. Maybe @andrisecker has some comments? |
He is trying it, once he's happy with the result, we can merge! |
d62e511
to
4f11d8f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1053 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 2421 2455 +34
=========================================
+ Hits 2421 2455 +34 |
@andrisecker , are you good with this? Is it doing what you wanted? |
@andrisecker are you still using this? do you think its worth merging or not? |
@arnaudon I'm not using it any more, but I think if I had this use case and it's already implemented then you should merge it. |
@eleftherioszisis I let you double check and approve this when you have time, as I cannot merge |
rebase is a pain, and this feature is not used, I discard.. |
By default the Sholl analysis is done wrt radial euclidean distance, but having path distance as an optional metric for Sholl analysis is sometimes useful.
This PR provides such functionality via an additional parameters
distance_type
.