Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include neuron filename extension into its name #909

Merged
merged 1 commit into from
May 7, 2021

Conversation

asanin-epfl
Copy link
Contributor

@asanin-epfl asanin-epfl commented May 6, 2021

Solution to #786,

Useful for morph stats when morphologies differ only by file extension

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@arnaudon do you think it could break anything?

@arnaudon
Copy link
Contributor

arnaudon commented May 7, 2021

it may not break anything, but I'm not sure this is a good option, different file format should have the same answer in morph_stat. If we want to test the possible differences, one can name 'my_morph_asc.asc' and 'my_morph_swc.swc' to compare the, no?

@asanin-epfl
Copy link
Contributor Author

asanin-epfl commented May 7, 2021

different file format should have the same answer in morph_stat.

Yes but it must not overwrite one file extension with another. Besides there might be different morphologies under the same name with different extensions. Distinguishing among file extensions, will help user to detect this problem.

If we want to test the possible differences, one can name 'my_morph_asc.asc' and 'my_morph_swc.swc' to compare the,

So, you manually added file extensions to names. How is that different from having file extensions?

@arnaudon
Copy link
Contributor

arnaudon commented May 7, 2021

Yes, this is a difficult thing to settle. My approach to it is to only distinguish morphologies by their names. I only work with a set of morphologies with consistent extensions, to avoid these issues. What I meant is that, if, as in the issue that triggered this PR, one want to extract morph_stats on 2 morphs with only a different extension (which is a very specific usecase I never had myself), one can change the names of the morphs to do that, instead of this PR.
What I like to have in a df for morphologies, is a column name with just Path('morph.asc').stem, and a column with the path to that morph on disk (where the extension is written). But this is just my way of doing things, it may not be the best!

But you can merge that, and we'll see in practice. It possibly won't affect anything at all.

@asanin-epfl asanin-epfl merged commit 3f631de into master May 7, 2021
@asanin-epfl asanin-epfl deleted the neuron-name-ext branch May 7, 2021 09:30
@asanin-epfl
Copy link
Contributor Author

Thank you, I'm merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants