Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all requirements txt files and update documentation accordingly #967

Merged
merged 5 commits into from
Sep 20, 2021
Merged

Delete all requirements txt files and update documentation accordingly #967

merged 5 commits into from
Sep 20, 2021

Conversation

asanin-epfl
Copy link
Contributor

@asanin-epfl asanin-epfl commented Sep 20, 2021 •
edited
Loading

Additionally optimize docs build

@asanin-epfl asanin-epfl self-assigned this Sep 20, 2021
@asanin-epfl asanin-epfl changed the title delete all requirements txt files and update documentation accordingly Delete all requirements txt files and update documentation accordingly Sep 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021 •
edited
Loading

Codecov Report

Merging #967 (bfc984b) into master (6f4c23a) will not change coverage.
The diff coverage is n/a.

❗ Current head bfc984b differs from pull request most recent head aec1f2f. Consider uploading reports for the commit aec1f2f to get more accurate results

@@            Coverage Diff            @@
##            master      #967   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2138      2138           
=========================================
  Hits          2138      2138

adrien-berchet
adrien-berchet reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo

doc/source/documentation.rst Outdated Show resolved Hide resolved
@asanin-epfl asanin-epfl merged commit abf25a2 into master Sep 20, 2021
@asanin-epfl asanin-epfl deleted the drop-requirements-txt branch September 20, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-berchet adrien-berchet adrien-berchet approved these changes

Assignees

@asanin-epfl asanin-epfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asanin-epfl @codecov-commenter @adrien-berchet