Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume density at the morphology level #996

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Add volume density at the morphology level #996

merged 7 commits into from
Mar 10, 2022

Conversation

eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented Mar 8, 2022 •
edited
Loading

  • Adds volume_density at the morphology level.
  • When a morphology is passed in get and volume_density is called, there is no more delegation to the neurite version of the feature
  • Adds exhaustive testing

Fixes #995

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #996 (0d415d3) into master (c570a2f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #996   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2334      2351   +17     
=========================================
+ Hits          2334      2351   +17

adrien-berchet
adrien-berchet reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

neurom/features/morphology.py Outdated Show resolved Hide resolved
neurom/geom/__init__.py Outdated Show resolved Hide resolved
tests/features/test_get_features.py Outdated Show resolved Hide resolved
mgeplf
mgeplf approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

@eleftherioszisis eleftherioszisis merged commit cfc7012 into master Mar 10, 2022
@eleftherioszisis eleftherioszisis deleted the zisis/fix-volume-density branch March 10, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-berchet adrien-berchet adrien-berchet approved these changes

@mgeplf mgeplf mgeplf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volume_density is not calculated correctly at the morphology level
4 participants
@eleftherioszisis @codecov-commenter @adrien-berchet @mgeplf