Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac python wheels #77

Merged
merged 7 commits into from
Mar 13, 2020
Merged

Mac python wheels #77

merged 7 commits into from
Mar 13, 2020

Conversation

mgeplf
Copy link
Contributor

@mgeplf mgeplf commented Mar 12, 2020

No description provided.

@mgeplf mgeplf requested a review from wizmer March 12, 2020 13:09
@wizmer
Copy link
Contributor

wizmer commented Mar 12, 2020

I had the same issue. I haven't solved it though. It seems that with this implementation, if you pip install . then you cannot run the tests from within the root folder. Hence: https://github.com/BlueBrain/MorphIO/blob/master/ci/python_test.sh#L24

However it works if you pip install -e ....

setup.py Show resolved Hide resolved
@mgeplf
Copy link
Contributor Author

mgeplf commented Mar 12, 2020

I had the same issue. I haven't solved it though

I have (basically the same fix). There isn't really a good solution that I know of. Idly wondering if pytest blocks file system local imports.

wizmer
wizmer previously approved these changes Mar 13, 2020
@wizmer wizmer self-requested a review March 13, 2020 09:15
wizmer
wizmer previously approved these changes Mar 13, 2020
@mgeplf mgeplf requested a review from wizmer March 13, 2020 10:08
@mgeplf mgeplf merged commit 1ce9962 into master Mar 13, 2020
@mgeplf mgeplf deleted the mac_python_wheels branch March 13, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants