std::function<double()> as alternative to double* #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/generic-handles
branch
3 times, most recently
from
cd5c174 to
034108f
Compare
olupton
force-pushed
the
olupton/generic-handles
branch
from
034108f to
ede01d9
Compare
6 tasks
olupton
requested review from
pramodk,
jorblancoa,
sergiorg-hpc and
iomaganaris
|
I added a unit test, but other than that LGTM! |
|
Looks like the CI might need to be bumped past ubuntu 18.04 |
olupton
force-pushed
the
olupton/generic-handles
branch
from
48b3526 to
8fbde2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support recording values that are obtained using generic handles (= things that can be dereferenced to yield a double value), instead of only supporting the special case that these handles are raw pointers.
This is needed for compatibility with neuronsimulator/nrn#2027.