Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load 'morphology' symbol during registration #1393

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Aug 9, 2024

This way if someone define again this symbol (in hoc file for example), neuron will use the right one during allocation of the module.

This is how it is currently done in nocmodl.

This behaviour has been spotted with nmodl benchmark.

This way if someone define again this symbol (in hoc file for example),
neuron will use the right one during allocation of the module.

This is how it is currently done in neuron.

This behaviour has been spotted with nmodl benchmark.
@alkino alkino requested a review from 1uc August 9, 2024 13:49
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (c5052b9) to head (9a6c7c7).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1393      +/-   ##
==========================================
- Coverage   86.75%   86.73%   -0.02%     
==========================================
  Files         180      180              
  Lines       13669    13674       +5     
==========================================
+ Hits        11858    11860       +2     
- Misses       1811     1814       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we can use get_variable_name("morphology_sym") to get the string we need to print. However, that requires that it's a "known" global variable. Which because it's type is not double is a little tricky.

There's also a risk of clashing with a GLOBAL variable called morphology_sym. Easily avoided by calling it _morphology_sym (since user defined variables cant' start with _).

I think it solves a real problem we're facing. Hence, I'd be okay merging it.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Aug 9, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Aug 9, 2024
@alkino alkino merged commit 86c2c66 into master Aug 12, 2024
24 checks passed
@alkino alkino deleted the cornu/morphology_double_rainbow branch August 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants