Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed POINTER compatibility error #821

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

iomaganaris
Copy link
Contributor

After merge of neuronsimulator/nrn#1622 POINTER variable shouldn't throw a compatibility error

@iomaganaris iomaganaris requested a review from pramodk March 13, 2022 15:29
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #42484 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk
Copy link
Contributor

pramodk commented Mar 14, 2022

@ioannis: not all pointer vars are safe so I wonder if we should show warning ⚠️ saying “if you are doing memory management for pointer variable then ….”.

@iomaganaris
Copy link
Contributor Author

I'll merge this PR so that the CI in other PRs doesn't fail and I created a ticket to handle the warning in another PR #822

@iomaganaris iomaganaris merged commit e26d961 into llvm Mar 14, 2022
@iomaganaris iomaganaris deleted the magkanar/pointer_check branch March 14, 2022 09:57
iomaganaris added a commit that referenced this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants