Avoid using raw pointers in InlineVisitor #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=======================================
Coverage 61.13% 61.13%
=======================================
Files 189 189
Lines 28342 28342
=======================================
Hits 17327 17327
Misses 11015 11015
Continue to review full report at Codecov.
|
|
Logfiles from GitLab pipeline #49317 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
force-pushed
the
magkanar/fix_m1_issue
branch
from
047205f to
acdb712
Compare
|
Logfiles from GitLab pipeline #52461 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
force-pushed
the
magkanar/fix_m1_issue
branch
from
acdb712 to
f2762ea
Compare
|
Logfiles from GitLab pipeline #60697 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of raw pointers in InlineVisitor seems like it generated bugs when running on the Apple M1 processor. Instead of using raw pointers handle cloning statements in need of replacing using
unique_ptr.Fixes #809
Note: Unfortunately I couldn't validate this in any way apart from running
NMODLmultiple times since valgrind is not working on mac. Before this change rerunningNMODLwith certain mod file would randomly crash with issues similar to the ones on mentioned on the above issue.