Semantic analysis check for USEION variables in CONSTANT block #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logfiles from GitLab pipeline #69939 (:white_check_mark:) have been uploaded here! Status and direct links: |
ohm314
approved these changes
Aug 18, 2022
|
Logfiles from GitLab pipeline #69996 (:white_check_mark:) have been uploaded here! Status and direct links: |
iomaganaris
approved these changes
Aug 22, 2022
6 tasks
* Similar to neuronsimulator/nrn#1955 * Add semantic analysis check to avoid declaring ion variables in CONSTANT {} block * Addresses first point in #888 MOD file is glia__dbbs_mod_collection__cdp5__CAM_GoC.mod. * Updated test
pramodk
force-pushed
the
pramodk/ion-var-as-constant
branch
2 times, most recently
from
2d6ba1a to
5a546de
Compare
Co-authored-by: Omar Awile <[email protected]>
pramodk
force-pushed
the
pramodk/ion-var-as-constant
branch
from
5a546de to
fee9a3b
Compare
|
Logfiles from GitLab pipeline #73670 (:white_check_mark:) have been uploaded here! Status and direct links: |
|
Logfiles from GitLab pipeline #73669 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
reviewed
Sep 9, 2022
|
Logfiles from GitLab pipeline #73702 (:white_check_mark:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in CONSTANT {} block
MOD file is glia__dbbs_mod_collection__cdp5__CAM_GoC.mod.