Log a critical instead of an assert if we cannot find the block to so…

[alkino]

…lved

Otherwise it only segmentation fault in Release

[alkino]

I'm not sure what we should do, how can we end the program there?
Is exit(1) good?

[bbpbuildbot]

Logfiles from GitLab pipeline #72530 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[codecov-commenter]

Codecov Report

Merging #922 (b3e2f23) into master (60249f1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   61.46%   61.46%   -0.01%     
==========================================
  Files         194      194              
  Lines       28457    28458       +1     
==========================================
  Hits        17492    17492              
- Misses      10965    10966       +1     

Impacted Files	Coverage Δ
src/visitors/solve_block_visitor.cpp	97.43% <50.00%> (-2.57%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[bbpbuildbot]

Logfiles from GitLab pipeline #72621 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[iomaganaris]

I was thinking that maybe based on Exceptions versus assertions an assertion fits here?

[useranonym]

I was thinking that maybe based on Exceptions versus assertions an assertion fits here?

that's true but assert is removed in non-debug builds and hence the problem?

[alkino]

@iomaganaris the problem of assert is that it is not executed with Release build. As this assertion is about conformance of mod files, it needs to be run all the time, as we cannot more trust the user input in Release that in Debug. I was running nmodl and i got a segfault without explanation on a buggy modfile.