Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate declaration of conductance variable g #929

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

pramodk
Copy link
Contributor

@pramodk pramodk commented Sep 9, 2022

  • when user defined g as a range variable in a non-threadsafe mod file, then instance structure was declaring g as a member variable twice
  • now, check if variable is already defined before adding new declaration
  • this is realted to Testing & Fixing issues with DBBS-Lab's MOD file collection #888 with mod file glia__dbbs_mod_collection__Nav1_1__0.mod

* when user defined g as a range variable in a non-threadsafe
  mod file, then instance structure was declaring g as a member
  variable twice
* now, check if variable is already defined before adding new
  declaration
* this is realted to #888 with mod file glia__dbbs_mod_collection__Nav1_1__0.mod
@pramodk pramodk added bug Something isn't working codegen Code generation backend labels Sep 9, 2022
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #73736 (:no_entry:) have been uploaded here!

Status and direct links:

@pramodk pramodk closed this Sep 9, 2022
@pramodk pramodk reopened this Sep 9, 2022
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #73746 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #73932 (:white_check_mark:) have been uploaded here!

Status and direct links:

Copy link
Contributor

@iomaganaris iomaganaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pramodk pramodk merged commit ea1acbd into master Sep 13, 2022
@pramodk pramodk deleted the pramodk/conductance-duplicate-member branch September 13, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codegen Code generation backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants