Store all nodes for a specific symbol

[alkino]

This way we can support the anti-feature of nrn having a function and a range variable having the same name

[pramodk]

overall looks fine! as discussed, adding unit test under visitor would be great!

[bbpbuildbot]

Logfiles from GitLab pipeline #74978 (:no_entry:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[bbpbuildbot]

Logfiles from GitLab pipeline #75027 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[bbpbuildbot]

Logfiles from GitLab pipeline #75240 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[bbpbuildbot]

Logfiles from GitLab pipeline #75385 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[codecov-commenter]

Codecov Report

Merging #934 (e289815) into master (ea1acbd) will increase coverage by 0.10%.
The diff coverage is 97.11%.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
+ Coverage   62.22%   62.32%   +0.10%     
==========================================
  Files         194      194              
  Lines       28341    28402      +61     
==========================================
+ Hits        17634    17701      +67     
+ Misses      10707    10701       -6     

Impacted Files	Coverage Δ
src/symtab/symbol_table.cpp	72.03% <75.00%> (+0.11%)	⬆️
src/language/templates/pybind/pysymtab.cpp	95.91% <100.00%> (ø)
src/symtab/symbol.cpp	94.44% <100.00%> (+4.44%)	⬆️
src/symtab/symbol.hpp	91.47% <100.00%> (+2.21%)	⬆️
src/visitors/inline_visitor.cpp	92.15% <100.00%> (-0.20%)	⬇️
src/visitors/solve_block_visitor.cpp	97.50% <100.00%> (+0.06%)	⬆️
src/visitors/symtab_visitor_helper.hpp	95.41% <100.00%> (ø)
test/unit/symtab/symbol_table.cpp	100.00% <100.00%> (ø)
src/language/templates/ast/ast.cpp	43.88% <0.00%> (+0.05%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ohm314]

Generally looks good, but maybe a few minor details to fix.

[pramodk]

few minor nitpicks otherwise good to go! 🚀

[pramodk]

(should have approved it with the previous review)

[bbpbuildbot]

Logfiles from GitLab pipeline #75492 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc