Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent is now useless, only check if variable is valid #966

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 17, 2022

INDEPENDENT are now doing nothing in nrn, do the same here

INDEPENDENT are now doing nothing in nrn, do the same here
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #79310 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino closed this Oct 17, 2022
@alkino alkino reopened this Oct 17, 2022
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #79366 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino changed the title Independent is now use less, only check if variable is valid Independent is now useless, only check if variable is valid Oct 18, 2022
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I took the liberty do a minor change and adding todo as a reminder.

@BlueBrain BlueBrain deleted a comment from bbpbuildbot Oct 20, 2022
@BlueBrain BlueBrain deleted a comment from bbpbuildbot Oct 20, 2022
@alkino alkino closed this Oct 20, 2022
@alkino alkino reopened this Oct 20, 2022
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #79837 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino merged commit 16a09e1 into master Oct 20, 2022
@alkino alkino deleted the cornu/disable_independent branch October 20, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants