-
Notifications
You must be signed in to change notification settings - Fork 15
Add recipe for Nix #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I was testing this on bb5, I took liberty to update your PR.
|
||
# gcc 4.9+ and higher supported with c++14 | ||
conflicts("%gcc@:4.8.99") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this conflict because on bb5 I was using system gcc 4.8.5 and I saw build was failing.
depends_on('autoconf') | ||
depends_on('automake') | ||
depends_on('bison') | ||
depends_on('curl') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also ok but many packages don't add curl explicitly because it's spack prerequisite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nix configure fails if curl dependency is not specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then good to add..
variant('data-dir', values=str, default=None, | ||
description='Data root directory (default is /nix)') | ||
variant('doc', values=bool, default=True, | ||
description="Build and install documentation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doc
variant is failing me on bb5:
GEN doc/manual/manual.is-valid
I/O error : Attempt to load network entity http://docbook.org/xml/5.0/rng/docbook.rng
warning: failed to load external entity "http://docbook.org/xml/5.0/rng/docbook.rng"
Relax-NG parser error : xmlRelaxNGParse: could not load http://docbook.org/xml/5.0/rng/docbook.rng
Relax-NG schema http://docbook.org/xml/5.0/rng/docbook.rng failed to compile
-:1: parser error : Document is empty
make: *** [doc/manual/manual.is-valid] Error 1
make: *** Waiting for unfinished jobs....
==> Error: ProcessError: Command exited with status 2:
'make' '-j16'
I see people suggesting docs to be disabled. Or, there might be a fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try with docbook
dependency. In the meantime, let's keep this PR open.
|
||
version('2.0.4', '045adeb4714f559386e391cc3c411710') | ||
variant('data-dir', values=str, default=None, | ||
description='Data root directory (default is /nix)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok but having -
in variant name sometime confuses. Because, package-A-B
on command lines "could" mean disable variant A
and B
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I will remove the -
.
To me PR is ready. What do you think @pramodk ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I am able to install this on BB5.
As you prefer: you can merge this as it is (using squash) Or separate two commits.
This pull-request allows me to install Nix on external super-computers.
@pramodskumbhar do you have feedback on those recipes?