Skip to content
This repository has been archived by the owner on Feb 26, 2025. It is now read-only.

Add recipe for Nix #36

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Add recipe for Nix #36

merged 2 commits into from
Jul 24, 2018

Conversation

tristan0x
Copy link
Member

This pull-request allows me to install Nix on external super-computers.
@pramodskumbhar do you have feedback on those recipes?

@tristan0x tristan0x requested a review from pramodskumbhar July 19, 2018 14:11
@tristan0x tristan0x added the enhancement New feature or request label Jul 19, 2018
Copy link

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was testing this on bb5, I took liberty to update your PR.


# gcc 4.9+ and higher supported with c++14
conflicts("%gcc@:4.8.99")

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this conflict because on bb5 I was using system gcc 4.8.5 and I saw build was failing.

depends_on('autoconf')
depends_on('automake')
depends_on('bison')
depends_on('curl')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also ok but many packages don't add curl explicitly because it's spack prerequisite.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix configure fails if curl dependency is not specified.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then good to add..

variant('data-dir', values=str, default=None,
description='Data root directory (default is /nix)')
variant('doc', values=bool, default=True,
description="Build and install documentation")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doc variant is failing me on bb5:

  GEN    doc/manual/manual.is-valid
I/O error : Attempt to load network entity http://docbook.org/xml/5.0/rng/docbook.rng
warning: failed to load external entity "http://docbook.org/xml/5.0/rng/docbook.rng"
Relax-NG parser error : xmlRelaxNGParse: could not load http://docbook.org/xml/5.0/rng/docbook.rng
Relax-NG schema http://docbook.org/xml/5.0/rng/docbook.rng failed to compile
-:1: parser error : Document is empty
make: *** [doc/manual/manual.is-valid] Error 1
make: *** Waiting for unfinished jobs....
==> Error: ProcessError: Command exited with status 2:
    'make' '-j16'

I see people suggesting docs to be disabled. Or, there might be a fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try with docbook dependency. In the meantime, let's keep this PR open.


version('2.0.4', '045adeb4714f559386e391cc3c411710')
variant('data-dir', values=str, default=None,
description='Data root directory (default is /nix)')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok but having - in variant name sometime confuses. Because, package-A-B on command lines "could" mean disable variant A and B.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will remove the -.

@tristan0x
Copy link
Member Author

To me PR is ready. What do you think @pramodk ?
If it's ok, I will change git history to have one commit per new package.

Copy link

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am able to install this on BB5.
As you prefer: you can merge this as it is (using squash) Or separate two commits.

@tristan0x tristan0x merged commit 3db3379 into develop Jul 24, 2018
@tristan0x tristan0x deleted the pkg/nix branch July 24, 2018 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants