Add ProxTVImage filter #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clean build did not help, I get the same errors: |
|
It looks like we are not percolating the list of include directories into the ITKImageProcessingServer target based on the ITK Modules that are needed. My guess is that there is some missing CMake code for the ITKImageProcessingServer target that needs to have the ITKTotalVariation module as a "target_include_directories" |
|
Your comment helped a lot. I needed to add |
This update just avoids syntax errors on reading the script. Trying to run this script using Python 3 causes an exception.
|
This gets much further on my computer:
After PR1 was merged, this compiles without issue! |
|
@imikejackson @thewtex this is ready for independent testing/merging! It worked with a simple 2D image on my computer. |
|
It might be a few days before I can get to the merge (for both this one and the one for the Superbuild). |
|
I am not in a hurry 🐌 😄 |
imikejackson
pushed a commit
to imikejackson/ITKImageProcessing
that referenced
this pull request
Sep 5, 2019
* Git on Linux really want this file to have LF line endings * Updating the filter creation script to parse with Python 3 This update just avoids syntax errors on reading the script. Trying to run this script using Python 3 causes an exception. * ENH: generate ProxTVImage filter, add it to source and test lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails to compile on my computer:
Indeed, the proper include directory is missing from the list of additional include directories. I will do a new clean build to see whether that will help. BlueQuartzSoftware/DREAM3DSuperbuild#17 is a prerequisite for this.