Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: defer initialization until ready() is called #103

Merged
merged 5 commits into from
Jul 16, 2021
Merged

config: defer initialization until ready() is called #103

merged 5 commits into from
Jul 16, 2021

Conversation

Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented May 6, 2021

No description provided.

@Bogdanp Bogdanp force-pushed the deferred-initialization branch 4 times, most recently from 0276d21 to e05d14a Compare May 6, 2021 06:55
@Bogdanp Bogdanp mentioned this pull request May 6, 2021
Closed
@Bogdanp Bogdanp force-pushed the deferred-initialization branch from 54826f4 to a7fc526 Compare June 14, 2021 05:42
@ikvk
Copy link

ikvk commented Jun 21, 2021

I think it is early to drop django 2, at least until 2022

Support timeline here: https://www.djangoproject.com/download/

For example peoples may using django 2 because:
Django 2.2 supports Oracle Database Server versions 12.1
Django 3.2 supports Oracle Database Server versions 12.2
*Oracle is pain :|

@Bogdanp
Copy link
Owner Author

Bogdanp commented Jun 21, 2021

Thanks! I've set the minimum to 2.2 for now.

@Bogdanp Bogdanp force-pushed the deferred-initialization branch from cda6234 to 6648d72 Compare July 8, 2021 12:52
@Bogdanp Bogdanp force-pushed the deferred-initialization branch from 6648d72 to 041a00c Compare July 8, 2021 12:56
@Bogdanp Bogdanp merged commit 041a00c into master Jul 16, 2021
@Bogdanp Bogdanp mentioned this pull request Aug 8, 2021
Closed
@Bogdanp Bogdanp deleted the deferred-initialization branch June 11, 2022 15:27
@amureki amureki mentioned this pull request Oct 31, 2022
Merged
Bogdanp pushed a commit that referenced this pull request Nov 5, 2022
@amureki @Bogdanp
Test scenario for #123
f66c22c 
This commit itself will break test suite, so we can later address issue in #123.
This bug was introduced in #103 where django_dramatiq started benefitting from `AppConfig.ready()` functionality.
There was a research done in #100 explaining the underlying issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bogdanp @ikvk