Optional setting DRAMATIQ_IGNORED_MODULES #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules appearing in DRAMATIQ_IGNORED_MODULES will be ignored by the rundramatiq management command.
This should reduce Cognitive Complexity
denizdogan
force-pushed
the
feature/ignored-modules
branch
from
b56cbc0 to
a636830
Compare
|
Phew, Code Climate took me by surprise, but hopefully this should be satisfactory... 😄 |
|
Thanks! I've merged this w/ rebase. I'll cut a release in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
I tried my best to follow the commit message standard and code style, flake8 had no complaints.
For the unit test, I decided to create a new test app,
testapp2, and rename the oldtestapptotestapp1to keep it somewhat consistent.Updated README with description of the feature.