Issue 184

[jamesros161]

This pull request is to resolve issue-184

The issues appears to be due to the set_writable_permissions() function not accounting for systems that do not use the ZipArchive package, but uses the PclZip package instead.

[bwmarkle]

@jamesros161 can we add some automated tests to ensure this is working as expected? To write those tests, it may help to separate the compressor logic into their own classes in the compressors folder.

[jamesros161]

@jamesros161 can we add some automated tests to ensure this is working as expected? To write those tests, it may help to separate the compressor logic into their own classes in the compressors folder.

Will do. I may have to revisit this whole thing since it was written before you added the System Zip functionality

[codecov-io]

Codecov Report

Merging #201 into master will increase coverage by 3.19%.
The diff coverage is 51.45%.

@@             Coverage Diff              @@
##             master     #201      +/-   ##
============================================
+ Coverage     20.42%   23.61%   +3.19%     
- Complexity     2547     2669     +122     
============================================
  Files           169      190      +21     
  Lines         12281    13001     +720     
============================================
+ Hits           2508     3070     +562     
- Misses         9773     9931     +158

Impacted Files	Coverage Δ	Complexity Δ
boldgrid-backup.php	0% <ø> (ø)	0 <0> (ø)	⬇️
admin/card/class-database-encryption.php	0% <0%> (ø)	1 <1> (?)
admin/card/class-history.php	0% <0%> (ø)	1 <1> (?)
admin/card/class-backups.php	0% <0%> (ø)	2 <0> (+1)	⬆️
...min/class-boldgrid-backup-admin-plugin-notices.php	0% <0%> (ø)	4 <4> (?)
admin/card/class-one-click-restoration.php	0% <0%> (ø)	1 <1> (?)
admin/partials/boldgrid-backup-admin-test.php	0% <0%> (ø)	0 <0> (ø)	⬇️
tests/bootstrap.php	0% <0%> (ø)	0 <0> (ø)	⬇️
admin/class-boldgrid-backup-admin-settings.php	23.45% <0%> (+11.11%)	145 <3> (ø)	⬇️
admin/card/class-historical-versions.php	0% <0%> (ø)	1 <1> (?)
... and 69 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb624c5...56025d4. Read the comment docs.

[cssjoe]

This method should be get_compressor_type or something starting with get_. When it starts with is_, I would expect the return to be a boolean.