Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore even if cannot set writable permissions. Fixes #437 #447

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bwmarkle
Copy link
Contributor

No description provided.

@bwmarkle
Copy link
Contributor Author

@cssjoe says:

the message changed to:
Total Upkeep - Restoration failed
Could not copy file.: wp-config.php
I chown 0:0 wp-config.php for the test restore.
It still says it failed. Should it say success with errors, or partially restored?

I'm going to put this PR on hold so we can get some releases out today.

  1. Looks like I missed some logic that needs to be accounted for.
  2. Thus far, only 1 report. Edge case?

@codecov-io
Copy link

codecov-io commented Feb 16, 2021

Codecov Report

Merging #447 (32c9ba5) into master (6d78a90) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     25.46%   25.46%           
  Complexity     2920     2920           
=========================================
  Files           202      202           
  Lines         14698    14697    -1     
=========================================
  Hits           3743     3743           
+ Misses        10955    10954    -1     
Impacted Files Coverage Δ Complexity Δ
admin/class-boldgrid-backup-admin-core.php 48.76% <ø> (+0.04%) 243.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d78a90...32c9ba5. Read the comment docs.

@cssjoe
Copy link
Member

cssjoe commented Mar 5, 2021

This may need better result messages.

  • Completes successfully
  • Completed with errors; partially restored -- Maybe have an expandable file list
  • Could not restore -- with the reason(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants