Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btn-large not consistent between button-primary and button-secondary #738

Closed
nicolepaschen opened this issue Sep 19, 2022 · 0 comments · Fixed by #747
Closed

btn-large not consistent between button-primary and button-secondary #738

nicolepaschen opened this issue Sep 19, 2022 · 0 comments · Fixed by #747
Labels
Niche Websites
Milestone
2.17.1

Comments

@nicolepaschen
Copy link
Member

I have the Customizer button design both set to large. The primary button uses a font size I didn't enter in the Customizer but the secondary button does. The padding for large buttons in a menu is off as well

large-buttons

https://demo2.cloudwp.dev/trial-3u8uy787/
@jamesros161 jamesros161 added this to the 2.17.1 milestone Sep 20, 2022
jamesros161 added a commit that referenced this issue Sep 30, 2022
@jamesros161
resolves #738
bec144f
@jamesros161 jamesros161 mentioned this issue Sep 30, 2022
Merged
jamesros161 added a commit that referenced this issue Oct 5, 2022
@jamesros161
Issues 738 & 733 (#740)
d026915 
* resolves #738

* Resolves #733

* update Buttons in yarn.lock

* generalize btn selectors

* update Buttons in yarn.lock
@jamesros161 jamesros161 mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Niche Websites
Projects
None yet
Milestone
2.17.1
Development

Successfully merging a pull request may close this issue.

Branch 2.17.1 BoldGrid/boldgrid-theme-framework
2 participants
@nicolepaschen @jamesros161