Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header overlay control should be conditionally visible #89

Closed
timelsass opened this issue May 11, 2019 · 0 comments · Fixed by #230 or #234
Closed

Header overlay control should be conditionally visible #89

timelsass opened this issue May 11, 2019 · 0 comments · Fixed by #230 or #234
Labels
bug General bug issues

Comments

@timelsass
Copy link
Member

Describe the bug
Header overlay control is visible when there is no video or image set to be displayed on the background. The control only changes the overlay on the header.

To Reproduce
Steps to reproduce the behavior:

  1. Go to WP Customizer
  2. Click on Design section
  3. Click on Header section
  4. Click on Background Section
  5. Make sure you don't have a background image or video set.
  6. Scroll down to bottom.

The result is that the header overlay control is visible.

Expected behavior
The header overlay control should only be visible when there is a background image or video present.

Screenshots
image

@jamesros161 jamesros161 added the bug General bug issues label May 28, 2020
jamesros161 added a commit that referenced this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bug issues
Projects
None yet
2 participants