feat: lazy websocket connection #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackstar12
force-pushed
the
feat/lazy-websocket
branch
2 times, most recently
from
28949a4 to
00565e4
Compare
only create actual websocket connection when there are pending swaps and close it if there are no more pending swaps
jackstar12
force-pushed
the
feat/lazy-websocket
branch
from
00565e4 to
78401ae
Compare
michael1011
requested changes
Feb 17, 2025
Comment on lines
+73
to
+75
| if boltz.state == closed { | ||
| return errors.New("websocket is closed") | ||
| } |
There was a problem hiding this comment.
Why can't we connect again when a websocket was closed once?
There was a problem hiding this comment.
Because the close call also causes the updates channel to be closed. Its not closed in this call to avoid a situation where we just got a message in the receiving goroutine and would then send on a closed channel
| @@ -201,6 +219,11 @@ func (boltz *Websocket) subscribe(swapIds []string) error { | |||
| } | |||
|
|
|||
| func (boltz *Websocket) Subscribe(swapIds []string) error { | |||
| if boltz.state == disconnected { | |||
| if err := boltz.Connect(); err != nil { | |||
There was a problem hiding this comment.
There should be a check here for len(swapIds) > 0 to make sure that we don't open and close the websocket instantly afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only create actual websocket connection when there are pending swaps and
close it if there are no more pending swaps