Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): check for release_created == 'true' #32

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

martinohmann
Copy link
Member

The docs of the release-please-action state that release_created is false if no release was created.

https://github.com/googleapis/release-please-action?tab=readme-ov-file#root-component-outputs

This is incorrect, release_created is empty in this case. An empty string in the enable attribute leads to an Invalid value error:

https://github.com/Bonial-International-GmbH/sops-check/actions/runs/12117567635/job/33780291842

We'll explicitly compare release_created to 'true' to make sure the result can only be true or false, but nothing else.

The docs of the `release-please-action` state that `release_created` is
`false` if no release was created.

https://github.com/googleapis/release-please-action?tab=readme-ov-file#root-component-outputs

This is incorrect, `release_created` is empty in this case. An empty
string in the `enable` attribute leads to an `Invalid value` error:

https://github.com/Bonial-International-GmbH/sops-check/actions/runs/12117567635/job/33780291842

We'll explicitly compare `release_created` to `'true'` to make sure the
result can only be `true` or `false`, but nothing else.
@martinohmann martinohmann requested a review from a team as a code owner December 2, 2024 10:48
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.06s
✅ DOCKERFILE hadolint 1 0 0.18s
✅ GO golangci-lint yes no 67.67s
✅ JSON jsonlint 3 0 0.4s
✅ JSON prettier 3 0 0.54s
✅ JSON v8r 3 0 2.05s
✅ MARKDOWN markdownlint 3 0 0.74s
✅ MARKDOWN markdown-link-check 4 0 9.58s
✅ MARKDOWN markdown-table-formatter 4 0 0.22s
✅ REPOSITORY checkov yes no 10.68s
✅ REPOSITORY gitleaks yes no 0.23s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 15.8s
✅ REPOSITORY secretlint yes no 0.81s
✅ REPOSITORY trivy yes no 10.46s
✅ REPOSITORY trivy-sbom yes no 0.15s
✅ REPOSITORY trufflehog yes no 4.36s
✅ YAML prettier 11 0 0.61s
✅ YAML v8r 11 0 11.92s
✅ YAML yamllint 11 0 0.33s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@martinohmann martinohmann merged commit 2fdb1cd into main Dec 2, 2024
3 checks passed
@martinohmann martinohmann deleted the mohmann/check-for-true branch December 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants