Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”ฅ [Update]: ๋ถˆํ•„์š”ํ•œ API ์‚ญ์ œ #24

Merged
merged 1 commit into from
Dec 26, 2023
Merged

๐Ÿ”ฅ [Update]: ๋ถˆํ•„์š”ํ•œ API ์‚ญ์ œ #24

merged 1 commit into from
Dec 26, 2023

Conversation

eomgerm
Copy link
Contributor

@eomgerm eomgerm commented Dec 5, 2023

๐Ÿ“ PR ํƒ€์ž… (ํ•˜๋‚˜ ์ด์ƒ ์„ ํƒ)

  • ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์˜์กด์„ฑ, ํ™˜๊ฒฝ ๋ณ€์ˆ˜, ๋นŒ๋“œ ๊ด€๋ จ ์ฝ”๋“œ ์—…๋ฐ์ดํŠธ
  • ๊ธฐํƒ€ ์‚ฌ์†Œํ•œ ์ˆ˜์ •

โ—๏ธ ๊ด€๋ จ ์ด์Šˆ ๋งํฌ

Close #23

๐Ÿ“Œ ๊ฐœ์š”

  • ๋ถˆํ•„์š”ํ•œ API ์‚ญ์ œ

๐Ÿ” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ์‚ฌ์šฉ์ž ๊ฒ€์ƒ‰ ์‚ญ์ œ
  • ์‚ฌ์šฉ์ž ์ถ”์ฒœ ์‚ญ์ œ
  • ์นœ๊ตฌ ์ถ”๊ฐ€/์‚ญ์ œ ์‚ญ์ œ
  • ํ™œ๋™ ๋ฆฌ๋ทฐ ์‚ญ์ œ
  • ๊ธฐ์กด ์ปค์Šคํ…€ UserRepository๋ฅผ ์‚ฌ์šฉํ•  ํ•„์š”๊ฐ€ ์—†์–ด์ ธ ๊ธฐ๋ณธ UserRepository๋กœ ๋Œ€์ฒด

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

๐Ÿ‘€ ๊ธฐํƒ€ ๋” ์ด์•ผ๊ธฐํ•ด๋ณผ ์ 

โœ… ์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • PR ํ…œํ”Œ๋ฆฟ์— ๋งž์ถ”์–ด ์ž‘์„ฑํ–ˆ์–ด์š”.
  • ๋ณ€๊ฒฝ ๋‚ด์šฉ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋ฅผ ์ง„ํ–‰ํ–ˆ์–ด์š”.
  • ํ”„๋กœ๊ทธ๋žจ์ด ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•ด์š”.
  • PR์— ์ ์ ˆํ•œ ๋ผ๋ฒจ์„ ์„ ํƒํ–ˆ์–ด์š”.
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์‚ญ์ œํ–ˆ์–ด์š”.

@eomgerm eomgerm added ๐Ÿ“ก API API ๊ด€๋ จ โฌ†๏ธ Update ์ฝ”๋“œ ์ˆ˜์ • labels Dec 5, 2023
@eomgerm eomgerm self-assigned this Dec 5, 2023
1000chw
1000chw approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@1000chw 1000chw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

@eomgerm eomgerm merged commit e321303 into master Dec 26, 2023
@eomgerm eomgerm deleted the update/23-delete-useless-apis branch December 26, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000chw 1000chw 1000chw approved these changes

Assignees

@eomgerm eomgerm

Labels
๐Ÿ“ก API API ๊ด€๋ จ โฌ†๏ธ Update ์ฝ”๋“œ ์ˆ˜์ •
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

โŒ [Update]: ๋ถˆํ•„์š”ํ•œ API ์ œ๊ฑฐ
2 participants
@eomgerm @1000chw