Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted books visible in list view #2111

Closed
Usinouv opened this issue May 10, 2020 · 1 comment
Closed

Restricted books visible in list view #2111

Usinouv opened this issue May 10, 2020 · 1 comment
Labels
🐛 Bug 🏭 Back-End 🔒 Security 🚀 Priority
Milestone
v0.29.3

Comments

@Usinouv
Copy link

Usinouv commented May 10, 2020

Describe the bug
On the shelf view, in list view, it is possible to see all the books, including the ones you can't access.
However, the home screen displays only the good books.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Giving restricted rights to a book
  2. Login with a user with restricted rights
  3. Click on "Shelves" from any page or add /shelves to the site url.
  4. Switch to list view

Expected behavior
Only authorized books should be visible whatever the view.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): 0.29.2
  • Hosting Method (Nginx/Apache/Docker): Docker - LinuxServer
@ssddanbrown ssddanbrown added this to the v0.29.3 milestone May 12, 2020
ssddanbrown added a commit that referenced this issue May 12, 2020
@ssddanbrown
Updated shelf-list view to enforce view permissions for child books
9666c8c 
- Aligned shelf-homepage behaviour to match
- Updated testing to cover.

For #2111
@ssddanbrown
Copy link
Member

Thank you very much @Usinouv for reporting this security issue and apologies such a vulnerability existed.

I have just released v0.29.3 to cover this:
https://github.com/BookStackApp/BookStack/releases/tag/v0.29.3

And have published a security advisory here:
GHSA-c32x-84w6-5mxq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 🏭 Back-End 🔒 Security 🚀 Priority
Milestone
v0.29.3
Development

No branches or pull requests
2 participants
@ssddanbrown @Usinouv