Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Level System #177

Merged
merged 9 commits into from
May 11, 2022
Merged

Refactor Level System #177

merged 9 commits into from
May 11, 2022

Conversation

hyv1001
Copy link
Collaborator

@hyv1001 hyv1001 commented May 11, 2022

Refactor Level System

  • Using smart pointer to manage resources in WorldManager and Level
  • Using GObjectID as object id instead of size_t
  • Using ObjectIDAllocator to allocate id
  • Just load the default level instead of all levels
  • Using character name as the current character key instead of the index

@hyv1001 hyv1001 requested a review from Ol6rin May 11, 2022 07:33
Ol6rin
Ol6rin requested changes May 11, 2022
View reviewed changes
engine/source/editor/include/editor_ui.h Outdated Show resolved Hide resolved
engine/source/editor/source/editor_ui.cpp Outdated Show resolved Hide resolved
engine/source/editor/source/editor_ui.cpp Outdated Show resolved Hide resolved
engine/source/editor/source/editor_ui.cpp Outdated Show resolved Hide resolved
engine/source/editor/source/editor_ui.cpp Outdated Show resolved Hide resolved
engine/source/runtime/function/framework/object/object_id_allocator.h Outdated Show resolved Hide resolved
engine/source/runtime/function/framework/world/world_manager.cpp Outdated Show resolved Hide resolved
engine/source/runtime/function/framework/world/world_manager.cpp Show resolved Hide resolved
engine/source/runtime/function/framework/world/world_manager.h Outdated Show resolved Hide resolved
engine/source/runtime/function/framework/world/world_manager.h Show resolved Hide resolved
@hyv1001 hyv1001 requested a review from Ol6rin May 11, 2022 14:22
@hyv1001 hyv1001 merged commit 83db902 into BoomingTech:main May 11, 2022
@hyv1001 hyv1001 deleted the refactor-level-system branch May 11, 2022 14:46
@hyv1001 hyv1001 mentioned this pull request May 18, 2022
Closed
KaygNas pushed a commit to KaygNas/Piccolo that referenced this pull request Feb 10, 2023
@hyv1001 @KaygNas
Refactor Level System (BoomingTech#177)
dd43bfa 
* load the default level instead of all levels
* using smart pointer to manager levels and objects
* using GObjectID instead of size_t as Object ID
* using ObjectIDAllocator to allocator object id
* using k_invalid_gobject_id to replace  PILOT_INVALID_GOBJECT_ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ol6rin Ol6rin Ol6rin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyv1001 @Ol6rin