Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Переработка фронтенда #61

Merged
merged 16 commits into from
Apr 27, 2023
Merged

Переработка фронтенда #61

merged 16 commits into from
Apr 27, 2023

Conversation

ConquestSucks
Copy link
Contributor

Переработал фронтэнд

@render
Copy link

render bot commented Apr 27, 2023

@render
Copy link

render bot commented Apr 27, 2023

@ConquestSucks ConquestSucks requested a review from newu2012 April 27, 2023 17:39
@newu2012
Copy link
Contributor

Нет аватарки по умолчанию?
Пока что так выглядит)
image

@ConquestSucks
Copy link
Contributor Author

Сейчас добавим

.gitignore Show resolved Hide resolved
BornToCode_Frontend/.env Outdated Show resolved Hide resolved
BornToCode_Frontend/.htaccess Show resolved Hide resolved
BornToCode_Frontend/package.json Outdated Show resolved Hide resolved
BornToCode_Frontend/package.json Outdated Show resolved Hide resolved
BornToCode_Frontend/src/views/profile-view.vue Outdated Show resolved Hide resolved
BornToCode_Frontend/public/index.html Outdated Show resolved Hide resolved
@@ -56,7 +58,7 @@ export default{
nickname: "",
aboutme: "",
file: "",
avatarUrl: '',
avatarUrl: '../assets/default_avatar.png',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Норм
image

<h1>Главная страница</h1>
<main>
<div class="main__upper">
<input type="text" id="search__bar" placeholder="Search..">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это уже стоило выносить отдельным коммитом.
У нас сейчас на каждый коммит при открытом PR идёт сборка, поэтому в таком случае стоит делать несколько локальных коммитов, а потом залить всё сразу, чтобы собирался только последний.
Кароч, просто чтобы он часы напролёт не билдил часто

@newu2012 newu2012 changed the title Develop Переработка фронтенда Apr 27, 2023
Copy link
Contributor

@newu2012 newu2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё тип-топ

@ConquestSucks ConquestSucks merged commit f054c64 into master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants