Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features for better UX #2

Merged
merged 10 commits into from
Feb 28, 2024

Conversation

Hacksore
Copy link
Contributor

@Hacksore Hacksore commented Feb 24, 2024

This will allow for a customCommitMessage and a ticketRegex to extract the ticket number from the feature branch.

WIP for now until #1 is merged.

❤️ ❤️ ❤️ ❤️ ❤️

cc @maxdemaio 🫶

@maxdemaio
Copy link
Contributor

maxdemaio commented Feb 24, 2024

Features Added Summary

The default is that this won't change anything. The user can opt in by adding in their settings.json in the .vscode folder of their repo things like:

{
  "saveMeBaby.commitMessage": "[WIP] {{ticket}} feature work",
  "saveMeBaby.useTicketRegex": true,
  "saveMeBaby.pushOnSave": false
}

If the useTicketRegex is not specified, it'll just use the commitMessage. If it's specified to be true, we parse the Jira ticket off the current branch with a regex and slap it wherever the user put {{ticket}} in their message. If it's set to true, they can also pass in a custom regex, but we have a default one set up. If they don't opt in at all, it's just default functionality using the previous commit in the git log.

Also, we can allow the user to allow auto push or not. By default it's on bc that was the original functionality.

@maxdemaio
Copy link
Contributor

Note: we'll rebase once #1 is in so it'll reflect our work

@Borwe
Copy link
Owner

Borwe commented Feb 24, 2024

Yeah this looks like cool feature to add 👍

@maxdemaio
Copy link
Contributor

Yeah this looks like cool feature to add 👍

I think all of our changes are all set!

@Hacksore Hacksore marked this pull request as ready for review February 26, 2024 17:55
@Hacksore Hacksore changed the title feat/allow custom git messages New features for better UX Feb 26, 2024
@Borwe
Copy link
Owner

Borwe commented Feb 27, 2024

Looks good for merging, BTW, mind adding like something on the README.md that explains how one can use this feature?

@maxdemaio
Copy link
Contributor

Looks good for merging, BTW, mind adding like something on the README.md that explains how one can use this feature?

Yes I can add a commit in the README.md, I'll drop a comment here when that's done!

@maxdemaio
Copy link
Contributor

@Borwe Should be all set with 83e22f1!

@Borwe
Copy link
Owner

Borwe commented Feb 28, 2024

Done bro, thanks alot.

@Borwe Borwe merged commit e68b523 into Borwe:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants