Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow small tolerance for negative pg/carbon data #133

Merged
merged 1 commit into from
Jul 7, 2020
Merged

fix: allow small tolerance for negative pg/carbon data #133

merged 1 commit into from
Jul 7, 2020

Conversation

danielolsen
Copy link
Contributor

Purpose

Avoid errors caused by small negative values.

What is the code doing

  • Change the check from < 0 to < -1 * tolerance
  • Simplify np.sum(x) > 0 to any(x)
  • Update the docstring

Time to review

Five minutes.

merrielle
merrielle approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@merrielle merrielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielolsen danielolsen force-pushed the tolerance_in_carbon_calcs branch from 7f57556 to 6534333 Compare July 7, 2020 23:00
@danielolsen danielolsen merged commit 54d8681 into develop Jul 7, 2020
@danielolsen danielolsen deleted the tolerance_in_carbon_calcs branch July 7, 2020 23:03
@ahurli ahurli mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrielle merrielle merrielle approved these changes

@victoriahunt victoriahunt Awaiting requested review from victoriahunt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielolsen @merrielle @victoriahunt