Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interconnection map and improve lmp map performance #136

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

merrielle
Copy link
Collaborator

Rebasing and re-merging this PR: #130

@kasparm
Copy link
Contributor

kasparm commented Jul 8, 2020

Could we make the commit message fix: lmp speed up bit more concise? What exactly speed up things?
Also there are some lines that don't give any information.
Let me know if you need help with that.

I understand it can be tedious to do that and it is easy to just squash but it helps understand what is happening.
Thank you

@merrielle merrielle force-pushed the map_improvement_rebased branch from c2b11be to c46f157 Compare July 8, 2020 21:06
@merrielle merrielle changed the title Map improvement rebased feat: add interconnection map and improve lmp map performance Jul 8, 2020
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Thanks

@merrielle merrielle merged commit 75877ba into develop Jul 8, 2020
@merrielle merrielle deleted the map_improvement_rebased branch July 8, 2020 21:18
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants