Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write check and helper functions #158

Merged
merged 6 commits into from
Sep 9, 2020
Merged

Write check and helper functions #158

merged 6 commits into from
Sep 9, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Sep 1, 2020

Purpose

Write helper and check functions that can be used by analysis and plot modules.

What is the code doing

This is a first batch of functions that can be used to support analysis and plotting modules. More will probably be written in the future. The functions are tested.

Where to look

  • the postreise.analyze.check module
  • the postreise.analyze.tests.test_check module

Time estimate

30min

@BainanXia
Copy link
Collaborator

All tests passed. Thanks for improving test coverage.

@rouille rouille force-pushed the ben/helpers branch 3 times, most recently from 77688e9 to 09d4abb Compare September 3, 2020 15:31
danielolsen
danielolsen approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a few comments about potential enhancements but I think this code is ready to get merged in.

jenhagg
jenhagg reviewed Sep 9, 2020
View reviewed changes
postreise/analyze/check.py Outdated Show resolved Hide resolved
jenhagg
jenhagg reviewed Sep 9, 2020
View reviewed changes
postreise/analyze/check.py Outdated Show resolved Hide resolved
jenhagg
jenhagg approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@jenhagg jenhagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rouille rouille merged commit b0c9ca5 into develop Sep 9, 2020
@rouille rouille deleted the ben/helpers branch September 9, 2020 21:33
@ahurli ahurli mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BainanXia BainanXia BainanXia left review comments

@jenhagg jenhagg jenhagg approved these changes

@danielolsen danielolsen danielolsen approved these changes

Assignees

@danielolsen danielolsen

@rouille rouille

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rouille @BainanXia @danielolsen @jenhagg