Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: expect datetime indices in tests with mock scenarios #166

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

danielolsen
Copy link
Contributor

@danielolsen danielolsen commented Sep 11, 2020

Piggy-backing on the improvement of mock objects in Breakthrough-Energy/PowerSimData#294, we need to refactor a few tests, so that they expect that the dataframes they get back will have time series indices. Tests will fail until Breakthrough-Energy/PowerSimData#294 is merged in.

Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@danielolsen danielolsen merged commit d4247b0 into develop Sep 11, 2020
@danielolsen danielolsen deleted the daniel/mock_indices branch September 11, 2020 22:41
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants